Support OSRAM lights on ZHA#11522
Merged
Merged
Conversation
emlove
force-pushed
the
zha-light-osram-support
branch
from
8b2f02f to
3a26da6
Compare
balloob
approved these changes
Jan 11, 2018
Merged
rcloran
reviewed
Jan 15, 2018
| # determine if the device supports color temperature. | ||
| discovery_info['color_capabilities'] = CAPABILITIES_COLOR_XY | ||
| result = yield from safe_read( | ||
| endpoint.light_color, ['color_temperature']) |
Contributor
There was a problem hiding this comment.
This breaks any lights which do not have a light_color attribute. I'm putting a fix together now.
Contributor
Author
There was a problem hiding this comment.
Ah damn. My mistake.
Probably what we should do is move most of this logic out of the constructor and into setup. Then this could be properly nested under the color cluster logic:
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
These bulbs are on an older version of the ZCL specification that doesn't support the color_capabilities attribute. This PR makes sure the supported_features for these devices are calculated properly.
Fixes #10036
Caveat: I haven't tested this on a light that doesn't support
color_capabilities(uses the new branch) and also doesn't support color_temperature.